[webkit-changes] [WebKit/WebKit] dc7bc5: WebKit::WebPageProxy::takeFocus() should take a We...

EWS noreply at github.com
Tue Jan 3 18:00:36 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dc7bc53309b5eda8f53fd8771933f2b69c48f135
      https://github.com/WebKit/WebKit/commit/dc7bc53309b5eda8f53fd8771933f2b69c48f135
  Author: David Kilzer <ddkilzer at apple.com>
  Date:   2023-01-03 (Tue, 03 Jan 2023)

  Changed paths:
    M Source/WebCore/page/FocusDirection.h
    M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Source/WebKit/UIProcess/WebPageProxy.messages.in
    M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp

  Log Message:
  -----------
  WebKit::WebPageProxy::takeFocus() should take a WebCore::FocusDirection
https://bugs.webkit.org/show_bug.cgi?id=249958
<rdar://65494875>

Reviewed by Alex Christensen.

Update WebPageProxy::takeFocus() to use the enum class
WebCore::FocusDirection type instead of uint32_t.

* Source/WebCore/page/FocusDirection.h:
- Fix formatting nit.

* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
- Add WebCore::FocusDirection enum class for IPC.

* Source/WebKit/UIProcess/WebPageProxy.cpp:
- Remove 'using namespace WebCore;' statement as drive-by
  clean-up.
(WebKit::WebPageProxy::takeFocus):
- Switch to use WebCore::FocusDirection type.
- Remove unneeded static_cast<> operators.
* Source/WebKit/UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::takeFocus):
- Switch to use WebCore::FocusDirection type.
* Source/WebKit/UIProcess/WebPageProxy.messages.in: Ditto.

* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::takeFocus):
- Remove unneeded static_cast<> operator.

Canonical link: https://commits.webkit.org/258415@main




More information about the webkit-changes mailing list