[webkit-changes] [WebKit/WebKit] 7eb369: Interaction: Have to tap twice to navigate on YouT...
megangardner
noreply at github.com
Tue Jan 3 17:59:31 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7eb369c661c68dfc878641ff4228bf3c12cdac96
https://github.com/WebKit/WebKit/commit/7eb369c661c68dfc878641ff4228bf3c12cdac96
Author: Megan Gardner <megan_gardner at apple.com>
Date: 2023-01-03 (Tue, 03 Jan 2023)
Changed paths:
M Source/WebCore/page/Quirks.cpp
M Source/WebCore/page/Quirks.h
M Source/WebCore/page/ios/ContentChangeObserver.cpp
M Source/WebCore/page/ios/ContentChangeObserver.h
M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
Log Message:
-----------
Interaction: Have to tap twice to navigate on YouTube search results
https://bugs.webkit.org/show_bug.cgi?id=249740
rdar://101981614
Reviewed by Tim Horton.
The Content Change Observer is triggered on the YouTube search page due to some
additional information that is presented on hover. This new UI isn't interactable
with additional clicks, so we should just ignore the CCO in this case and let the
click fully register which allows the link to be followed with one click instead of
two.
* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::shouldDisableContentChangeObserver const):
* Source/WebCore/page/Quirks.h:
* Source/WebCore/page/ios/ContentChangeObserver.cpp:
(WebCore::isContentChangeObserverEnabled):
(WebCore::ContentChangeObserver::startContentObservationForDuration):
(WebCore::ContentChangeObserver::didAddTransition):
(WebCore::ContentChangeObserver::didInstallDOMTimer):
(WebCore::ContentChangeObserver::rendererWillBeDestroyed):
(WebCore::ContentChangeObserver::touchEventDidStart):
(WebCore::ContentChangeObserver::touchEventDidFinish):
(WebCore::ContentChangeObserver::mouseMovedDidStart):
(WebCore::ContentChangeObserver::mouseMovedDidFinish):
* Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::handleSyntheticClick):
(WebKit::WebPage::completeSyntheticClick):
Canonical link: https://commits.webkit.org/258414@main
More information about the webkit-changes
mailing list