[webkit-changes] [WebKit/WebKit] 4e08fd: build-webkit: Don't remove CMakeFiles directory

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4e08fdf961013ac6b1551cf4715402e261a2aa41
      https://github.com/WebKit/WebKit/commit/4e08fdf961013ac6b1551cf4715402e261a2aa41
  Author: Fujii Hironori <Hironori.Fujii at sony.com>
  Date:   2023-02-20 (Mon, 20 Feb 2023)

  Changed paths:
    M Tools/Scripts/webkitdirs.pm

  Log Message:
  -----------
  build-webkit: Don't remove CMakeFiles directory
https://bugs.webkit.org/show_bug.cgi?id=252548

Reviewed by Michael Catanzaro.

build-webkit script removed both CMakeCache.txt and CMakeFiles
directory to reconfigure if necessary. This was suggested by the CMake
developer to work around a CMake problem.

However, removing CMakeFiles directory introduced another problem.
And, the original CMake problem was fixed by CMake 3.8.
<https://gitlab.kitware.com/cmake/cmake/-/issues/13934#note_200624>

Steps to reproduce the problem with WinCairo port:

1. Invoke perl .\Tools\Scripts\build-webkit
   CMakeLists.txt and CMakeFiles directory are created.
2. Add "message(FATAL_ERROR)" to Source/cmake/OptionsCommon.cmake
3. Invoke perl .\Tools\Scripts\build-webkit
   CMakeLists.txt and CMakeFiles directory are removed.
   Only CMakeLists.txt is created.
4. Invoke perl .\Tools\Scripts\build-webkit
   It reports the following error

> ninja: error: build.ninja:35: loading 'CMakeFiles\rules.ninja': The system cannot find the file specified.
> include CMakeFiles\rules.ninja
>                               ^ near here

Reverted bug#165008 change.

* Tools/Scripts/webkitdirs.pm:
(removeCMakeCache):
(cmakeFilesPath): Deleted.

Canonical link: https://commits.webkit.org/260563@main