[webkit-changes] [WebKit/WebKit] f6adb7: Fix entry tier-up SIMD check in BBQ baseline JIT

EWS noreply at github.com
Mon Feb 20 13:17:11 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f6adb76413178eb10820c04b14cffd501a981e88
      https://github.com/WebKit/WebKit/commit/f6adb76413178eb10820c04b14cffd501a981e88
  Author: David Degazio <d_degazio at apple.com>
  Date:   2023-02-20 (Mon, 20 Feb 2023)

  Changed paths:
    M Source/JavaScriptCore/wasm/WasmBBQJIT.cpp

  Log Message:
  -----------
  Fix entry tier-up SIMD check in BBQ baseline JIT
https://bugs.webkit.org/show_bug.cgi?id=252590
rdar://105689397

Currently, the new WebAssembly BBQ baseline JIT always passes false for the isSIMD
parameter when calling into the OMG tier-up trigger thunk. This patch makes it so
we track whether the function is a SIMD function using notifyFunctionUsesSIMD(),
and pass that into the thunk generator, ensuring we preserve any SIMD registers
used to pass arguments to the function.

Reviewed by Yusuke Suzuki.

* Source/JavaScriptCore/wasm/WasmBBQJIT.cpp:
(JSC::Wasm::BBQJIT::emitEntryTierUpCheck):
(JSC::Wasm::BBQJIT::notifyFunctionUsesSIMD):

Canonical link: https://commits.webkit.org/260562@main




More information about the webkit-changes mailing list