[webkit-changes] [WebKit/WebKit] b4f656: ManagedMediaExtension missing SkipVTableValidation...

Jean-Yves Avenard noreply at github.com
Thu Feb 16 04:30:42 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b4f656f61284ad79a2ea18d0227887eb112af8c0
      https://github.com/WebKit/WebKit/commit/b4f656f61284ad79a2ea18d0227887eb112af8c0
  Author: Jean-Yves Avenard <jya at apple.com>
  Date:   2023-02-16 (Thu, 16 Feb 2023)

  Changed paths:
    M LayoutTests/media/media-source/content/test-vorbis-manifest.json
    M LayoutTests/media/media-source/content/test-xhe-aac-manifest.json
    A LayoutTests/media/media-source/media-managedmse-expected.txt
    A LayoutTests/media/media-source/media-managedmse.html
    M LayoutTests/media/media-source/media-source-loader.js
    M LayoutTests/platform/glib/TestExpectations
    M Source/WebCore/Modules/mediasource/MediaSource.idl
    M Source/WebCore/Modules/mediasource/SourceBuffer.idl

  Log Message:
  -----------
  ManagedMediaExtension missing SkipVTableValidation in IDL
https://bugs.webkit.org/show_bug.cgi?id=252307
rdar://105489108

Reviewed by Cameron McCormack.

ManagedMediaSource and ManagedSourceBuffer inherit from MediaSource
and SourceBuffer respectively.
As such, both MediaSource and SourceBuffer need SkipVTableValidation
keyword in their IDL definition to avoid
`RELEASE_ASSERT(actualVTablePointer == expectedVTablePointer);`

Added some minimal tests working on all platforms.

* LayoutTests/platform/glib/TestExpectations: Skip test for now (see bug 252386)
* LayoutTests/media/media-source/content/test-vorbis-manifest.json: Fix duration.
* LayoutTests/media/media-source/content/test-xhe-aac-manifest.json: Fix duration.
* LayoutTests/media/media-source/media-managedmse-expected.txt: Added.
* LayoutTests/media/media-source/media-managedmse.html: Added.
* LayoutTests/media/media-source/media-source-loader.js:
(MediaSourceLoader.prototype.mediaSegmentEndTime): Add method.
* Source/WebCore/Modules/mediasource/MediaSource.idl:
* Source/WebCore/Modules/mediasource/SourceBuffer.idl:

Canonical link: https://commits.webkit.org/260360@main




More information about the webkit-changes mailing list