[webkit-changes] [WebKit/WebKit] 0faaa0: Drop tag arguments early on backends than don't us...

aoikonomopoulos noreply at github.com
Thu Feb 16 03:37:54 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0faaa00680c05d74beb242290abcd539243e0222
      https://github.com/WebKit/WebKit/commit/0faaa00680c05d74beb242290abcd539243e0222
  Author: Angelos Oikonomopoulos <angelos at igalia.com>
  Date:   2023-02-16 (Thu, 16 Feb 2023)

  Changed paths:
    M Source/JavaScriptCore/offlineasm/arm.rb
    M Source/JavaScriptCore/offlineasm/arm64.rb
    M Source/JavaScriptCore/offlineasm/arm64e.rb
    M Source/JavaScriptCore/offlineasm/mips.rb
    M Source/JavaScriptCore/offlineasm/risc.rb
    M Source/JavaScriptCore/offlineasm/riscv64.rb

  Log Message:
  -----------
  Drop tag arguments early on backends than don't use them
https://bugs.webkit.org/show_bug.cgi?id=251603

Reviewed by Yusuke Suzuki.

The extra arguments to call/jmp for pointer tagging are only used on
arm64e. However, on all risc platforms, riscLowerMalformedImmediates
will emit extra code to load the values in a register.

Instead, drop the extra tag arguments early so that none of the other
passes can get confused.

* Source/JavaScriptCore/offlineasm/arm.rb:
* Source/JavaScriptCore/offlineasm/arm64.rb:
* Source/JavaScriptCore/offlineasm/arm64e.rb:
* Source/JavaScriptCore/offlineasm/mips.rb:
* Source/JavaScriptCore/offlineasm/risc.rb:
* Source/JavaScriptCore/offlineasm/riscv64.rb:

Canonical link: https://commits.webkit.org/260359@main




More information about the webkit-changes mailing list