[webkit-changes] [WebKit/WebKit] 397d48: Enable libc++ assertions on tvOS and watchOS

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 397d4819ff662f431d4da6eed591219140178c9f
      https://github.com/WebKit/WebKit/commit/397d4819ff662f431d4da6eed591219140178c9f
  Author: David Kilzer <ddkilzer at apple.com>
  Date:   2023-02-10 (Fri, 10 Feb 2023)

  Changed paths:
    M Configurations/CommonBase.xcconfig
    M Configurations/WebKitTargetConditionals.xcconfig
    M Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig
    M Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig
    M Source/WebCore/Configurations/WebCore.xcconfig
    M Source/WebCore/PAL/Configurations/PAL.xcconfig
    M Source/WebKit/Configurations/BaseTarget.xcconfig
    M Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig

  Log Message:
  -----------
  Enable libc++ assertions on tvOS and watchOS
https://bugs.webkit.org/show_bug.cgi?id=252066

Reviewed by Elliott Williams.

Define LIBCPP_ASSERTIONS_CFLAGS for tvOS and watchOS (and add a
WK_ prefix) to enable libc++ assertions on those platforms, and
define target conditional macros for watchOS.

* Configurations/CommonBase.xcconfig:
- Move definition of macro here to remove duplicate definitions
  in various project xcconfig files listed below.
- Rename LIBCPP_ASSERTIONS_CFLAGS to WK_LIBCPP_ASSERTIONS_CFLAGS
  to prevent name collisions.
- Add variants for tvOS and watchOS to fix the bug.
* Configurations/WebKitTargetConditionals.xcconfig:
- Define WATCH_OS_9 and WATCH_OS_10 target conditionals.

* Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig:
* Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig:
* Source/WebCore/Configurations/WebCore.xcconfig:
* Source/WebCore/PAL/Configurations/PAL.xcconfig:
* Source/WebKit/Configurations/BaseTarget.xcconfig:
* Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig:
- Move definition of LIBCPP_ASSERTIONS_CFLAGS to
  Configurations/CommonBase.xcconfig.
- Update to replace use of LIBCPP_ASSERTIONS_CFLAGS with
  WK_LIBCPP_ASSERTIONS_CFLAGS.

Canonical link: https://commits.webkit.org/260144@main