[webkit-changes] [WebKit/WebKit] b6c718: Table with fixed layout behaves like auto layout w...
Ahmad Saleem
noreply at github.com
Fri Feb 10 20:06:03 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b6c71868cecccf5d205892dc0688a40504eda3b9
https://github.com/WebKit/WebKit/commit/b6c71868cecccf5d205892dc0688a40504eda3b9
Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
Date: 2023-02-10 (Fri, 10 Feb 2023)
Changed paths:
A LayoutTests/fast/table/fixed-table-layout-width-change-expected.txt
A LayoutTests/fast/table/fixed-table-layout-width-change.html
M Source/WebCore/rendering/RenderTable.cpp
M Source/WebCore/rendering/style/RenderStyle.h
Log Message:
-----------
Table with fixed layout behaves like auto layout when its width is set by JS instead of css
Table with fixed layout behaves like auto layout when its width is set by JS instead of css
https://bugs.webkit.org/show_bug.cgi?id=130239
Reviewed by Alan Baradlay.
This patch is to align WebKit with Blink / Chromium and Gecko / Firefox.
Merge - https://chromium.googlesource.com/chromium/blink/+/17dc4cd863992d6f9932ba40d5cf41a1389dfa97
The new width of table was not being applied when changed dynamically
even though the table-layout is fixed.
On calculating whether we need to set the m_tableLayout as fixed or
auto the change in layout parameters such as width, height etc was
not considered hence the right layout type was not being set. Incase
there are any layout changes we need to see whether m_tableLayout
needs to be changed or not.
* Source/WebCore/rendering/RenderTable.cpp:
(RenderTable::styleDidChange): Update as per commit message
* Source/WebCore/rendering/style/RenderStyle.h: Add bool 'isFixedTableLayout' with return value
* LayoutTests/fast/table/fixed-table-layout-width-change.html: Add Test Case
* LayoutTests/fast/table/fixed-table-layout-width-change-expected.txt: Add Test Case Expectation
Canonical link: https://commits.webkit.org/260143@main
More information about the webkit-changes
mailing list