[webkit-changes] [WebKit/WebKit] 428476: [curl] CloseEvent has wasClean=true and no error c...
Fujii Hironori
noreply at github.com
Wed Feb 8 12:03:31 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 42847605cf96636afb6059426edf7c7b3ed9adb5
https://github.com/WebKit/WebKit/commit/42847605cf96636afb6059426edf7c7b3ed9adb5
Author: Fujii Hironori <Hironori.Fujii at sony.com>
Date: 2023-02-08 (Wed, 08 Feb 2023)
Changed paths:
A LayoutTests/http/tests/websocket/tests/hybi/server-close-2-expected.txt
A LayoutTests/http/tests/websocket/tests/hybi/server-close-2.html
A LayoutTests/http/tests/websocket/tests/hybi/server-close-2_wsh.py
M Source/WebKit/NetworkProcess/curl/WebSocketTaskCurl.cpp
Log Message:
-----------
[curl] CloseEvent has wasClean=true and no error code when the WebSocket connection got terminated from the server side
https://bugs.webkit.org/show_bug.cgi?id=240227
Reviewed by Don Olmstead.
It should return a correct error code rather than 0.
* LayoutTests/http/tests/websocket/tests/hybi/server-close-2-expected.txt: Added.
* LayoutTests/http/tests/websocket/tests/hybi/server-close-2.html: Added.
* LayoutTests/http/tests/websocket/tests/hybi/server-close-2_wsh.py: Added.
* Source/WebKit/NetworkProcess/curl/WebSocketTaskCurl.cpp:
(WebKit::WebSocketTask::didReceiveData):
Use WebSocketChannel::CloseEventCode::CloseEventCodeAbnormalClosure if
the connection disconnected.
Canonical link: https://commits.webkit.org/260025@main
More information about the webkit-changes
mailing list