[webkit-changes] [WebKit/WebKit] 9215d7: Navigation within iframe doesn't exit fullscreen f...

Tim Nguyen noreply at github.com
Wed Feb 8 11:55:29 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9215d7d582cb6d40cb439a45cb2157ab9bcbb575
      https://github.com/WebKit/WebKit/commit/9215d7d582cb6d40cb439a45cb2157ab9bcbb575
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2023-02-08 (Wed, 08 Feb 2023)

  Changed paths:
    A LayoutTests/fullscreen/fullscreen-iframe-navigation-expected.html
    A LayoutTests/fullscreen/fullscreen-iframe-navigation.html
    A LayoutTests/fullscreen/resources/fullscreen-iframe-navigation-target.html
    M LayoutTests/platform/mac-wk1/TestExpectations
    M Source/WebCore/dom/FullscreenManager.cpp
    M Source/WebCore/dom/FullscreenManager.h

  Log Message:
  -----------
  Navigation within iframe doesn't exit fullscreen for parent iframe element
https://bugs.webkit.org/show_bug.cgi?id=251896
rdar://104393093

Reviewed by Chris Dumez.

This was because the exiting document was already detached from the Frame object, causing it to fail to find the top document.
To fix this, we store the top document when initializing FullscreenManager.

* LayoutTests/fullscreen/fullscreen-iframe-navigation-expected.html: Added.
* LayoutTests/fullscreen/fullscreen-iframe-navigation.html: Added.
* LayoutTests/fullscreen/resources/fullscreen-iframe-navigation-target.html: Added.
* LayoutTests/platform/mac-wk1/TestExpectations:
* Source/WebCore/dom/FullscreenManager.cpp:
(WebCore::FullscreenManager::cancelFullscreen):
(WebCore::documentsToUnfullscreen):
(WebCore::FullscreenManager::exitFullscreen):
(WebCore::FullscreenManager::finishExitFullscreen):
(WebCore::FullscreenManager::didExitFullscreen):
* Source/WebCore/dom/FullscreenManager.h:

Canonical link: https://commits.webkit.org/260024@main




More information about the webkit-changes mailing list