[webkit-changes] [WebKit/WebKit] c60391: configureForNetworkConnectionIntegrity() should no...

Charlie Wolfe noreply at github.com
Tue Feb 7 20:36:10 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c603913ff2dd0f1a744f3b3abeb35c4c959be55c
      https://github.com/WebKit/WebKit/commit/c603913ff2dd0f1a744f3b3abeb35c4c959be55c
  Author: Charlie Wolfe <charliew at apple.com>
  Date:   2023-02-07 (Tue, 07 Feb 2023)

  Changed paths:
    M Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm
    M Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm

  Log Message:
  -----------
  configureForNetworkConnectionIntegrity() should not be called unconditionally
https://bugs.webkit.org/show_bug.cgi?id=251819
rdar://104709975

Reviewed by Wenson Hsieh.

We should only call configureForNetworkConnectionIntegrity() when the network
connection integrity policy is enabled. This will race this function call against
the resources loaded after the main frame, which should be fine.

* Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
* Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::SessionWrapper::initialize):
(WebKit::NetworkSessionCocoa::clearCredentials):
(WebKit::createURLSession): Deleted.

Canonical link: https://commits.webkit.org/259991@main




More information about the webkit-changes mailing list