[webkit-changes] [WebKit/WebKit] f26fd7: A test case in imported/w3c/web-platform-tests/sha...
Ryosuke Niwa
noreply at github.com
Tue Feb 7 19:41:11 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f26fd78b87fac7cd22403c70603b496cea16e9db
https://github.com/WebKit/WebKit/commit/f26fd78b87fac7cd22403c70603b496cea16e9db
Author: Ryosuke Niwa <rniwa at webkit.org>
Date: 2023-02-07 (Tue, 07 Feb 2023)
Changed paths:
M LayoutTests/imported/w3c/web-platform-tests/shadow-dom/focus/click-focus-delegatesFocus-click-expected.txt
M Source/WebCore/dom/Element.cpp
M Source/WebCore/dom/Element.h
M Source/WebCore/page/EventHandler.cpp
Log Message:
-----------
A test case in imported/w3c/web-platform-tests/shadow-dom/focus/click-focus-delegatesFocus-click.html fails
https://bugs.webkit.org/show_bug.cgi?id=251897
Reviewed by Tim Nguyen.
The bug was caused by EventHandler::dispatchMouseEvent traversing over the composed tree.
This part of the spec has been re-written to use focus delegate so reuse findFocusDelegateInternal in Element.cpp,
which has been now renamed to findFocusDelegateForTarget, to find the focus delegate.
* LayoutTests/imported/w3c/web-platform-tests/shadow-dom/focus/click-focus-delegatesFocus-click-expected.txt:
* Source/WebCore/dom/Element.cpp:
(WebCore::autoFocusDelegate):
(WebCore::Element::findFocusDelegateForTarget): Renamed from findFocusDelegateInternal.
(WebCore::Element::findFocusDelegate):
(WebCore::Element::focus):
* Source/WebCore/dom/Element.h:
* Source/WebCore/page/EventHandler.cpp:
(WebCore::EventHandler::dispatchMouseEvent):
(WebCore::findFirstMouseFocusableElementInComposedTree): Deleted.
Canonical link: https://commits.webkit.org/259990@main
More information about the webkit-changes
mailing list