[webkit-changes] [WebKit/WebKit] 7451a6: Cherry-pick e0e146fe111c. rdar://problem/104881175

Timothy Hatcher noreply at github.com
Tue Feb 7 15:20:16 PST 2023


  Branch: refs/heads/safari-7616.1.1-branch
  Home:   https://github.com/WebKit/WebKit
  Commit: 7451a6eae74775a43e01ff59b961ffb757aa3432
      https://github.com/WebKit/WebKit/commit/7451a6eae74775a43e01ff59b961ffb757aa3432
  Author: Andres Gonzalez <andresg_22 at apple.com>
  Date:   2023-02-07 (Tue, 07 Feb 2023)

  Changed paths:
    M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm

  Log Message:
  -----------
  Cherry-pick e0e146fe111c. rdar://problem/104881175

    AX: Retain AXTextMarkerRefs and AXTextMarkerRangeRefs passed from the AX thread to the main thread.
    https://bugs.webkit.org/show_bug.cgi?id=251451
    <rdar://problem/104881175>

    Reviewed by Chris Fleizach.

    * Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
    (-[WebAccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:spellCheck:]):
    (-[WebAccessibilityObjectWrapper _accessibilitySetValue:forAttribute:]):
    (-[WebAccessibilityObjectWrapper _indexForTextMarker:]):
    (-[WebAccessibilityObjectWrapper textMarkerRangeAtTextMarker:forUnit:]):
    (-[WebAccessibilityObjectWrapper lineTextMarkerRangeForTextMarker:forUnit:]):
    (-[WebAccessibilityObjectWrapper textMarkerForTextMarker:atUnit:]):
    (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

    Canonical link: https://commits.webkit.org/259918@main


  Commit: 553d02d5f4eb82cb535cd65c4c9bce9fbabc21f9
      https://github.com/WebKit/WebKit/commit/553d02d5f4eb82cb535cd65c4c9bce9fbabc21f9
  Author: Andres Gonzalez <andresg_22 at apple.com>
  Date:   2023-02-07 (Tue, 07 Feb 2023)

  Changed paths:
    M Source/WebCore/accessibility/AXObjectCache.cpp
    M Source/WebCore/accessibility/AXObjectCache.h

  Log Message:
  -----------
  Cherry-pick c11d33bb0bb2. rdar://problem/104956200

    AX: Object IDs should not be generated with AXTreeStore::generateNewID().
    https://bugs.webkit.org/show_bug.cgi?id=251577
    <rdar://problem/104956200>

    Reviewed by Chris Fleizach.

    In the patch for
        https://bugs.webkit.org/show_bug.cgi?id=249480
        <rdar://problem/103449294>

    I erroneously switched the generation of object IDS in the AXObjectCache to use AXTreeStore::generateNewID. This is wrong because generateNewID checks the presence of the ID against the IDs of AX trees and not against object IDs. This patch rectifies this by bringing back AXObjectCache::generateNewObjectID (new name).

    * Source/WebCore/accessibility/AXObjectCache.cpp:
    (WebCore::AXObjectCache::generateNewObjectID const):
    (WebCore::AXObjectCache::getAXID):
    * Source/WebCore/accessibility/AXObjectCache.h:
    (WebCore::AXObjectCache::objectForID const): No need to pass AXID by reference since it just wraps an unsgined.

    Canonical link: https://commits.webkit.org/259922@main


  Commit: 233599b2aa6d10557e8553ee3bfe3f0593f3a52e
      https://github.com/WebKit/WebKit/commit/233599b2aa6d10557e8553ee3bfe3f0593f3a52e
  Author: Timothy Hatcher <timothy at apple.com>
  Date:   2023-02-07 (Tue, 07 Feb 2023)

  Changed paths:
    M Source/WebKit/NetworkProcess/NetworkProcess.cpp
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm

  Log Message:
  -----------
  Cherry-pick d8706351a89a. rdar://problem/103793194

    Cross-Origin-Resource-Policy blocks fetch from extensions.
    https://webkit.org/b/251858
    rdar://103793194

    Reviewed by Chris Dumez.

    SecurityPolicy was blocking the fetch load due to the Cross-Origin-Resource-Policy check
    in the NetworkProcess. In the WebProcess, SecurityPolicy checks were succeeding due to the
    existing call to SecurityPolicy::allowAccessTo() when parsing the corsDisablingPatterns.
    This step was missing in the NetworkProcess. Now both processes have the same checks.

    * Source/WebKit/NetworkProcess/NetworkProcess.cpp:
    (WebKit::NetworkProcess::setCORSDisablingPatterns): Add the pattern to SecurityPolicy to
    match WebPage.cpp's parseAndAllowAccessToCORSDisablingPatterns().
    * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
    (TEST(URLSchemeHandler, DisableCORSAndCORP)): Added.

    Canonical link: https://commits.webkit.org/259976@main


Compare: https://github.com/WebKit/WebKit/compare/69938dbb05fd...233599b2aa6d


More information about the webkit-changes mailing list