[webkit-changes] [WebKit/WebKit] d33463: Make some minor adjustments when getting screenX/s...

Wenson Hsieh noreply at github.com
Tue Feb 7 14:47:35 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d33463727a4a61def19c0671960e5a51f6ecff80
      https://github.com/WebKit/WebKit/commit/d33463727a4a61def19c0671960e5a51f6ecff80
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2023-02-07 (Tue, 07 Feb 2023)

  Changed paths:
    M Source/WebCore/loader/DocumentLoader.cpp
    M Source/WebCore/loader/DocumentLoader.h
    M Source/WebCore/page/DOMWindow.cpp
    M Tools/TestWebKitAPI/cocoa/TestUIDelegate.h
    M Tools/TestWebKitAPI/cocoa/TestUIDelegate.mm

  Log Message:
  -----------
  Make some minor adjustments when getting screenX/screenY in headless mode
https://bugs.webkit.org/show_bug.cgi?id=251825
rdar://105105306

Reviewed by Aditya Keerthi.

Return a sensible fallback value for `window.screenX` and `window.screenY`, when
`isLoadingInHeadlessMode()` returns `true`.

* Source/WebCore/loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::isLoadingInHeadlessMode const):
* Source/WebCore/loader/DocumentLoader.h:
* Source/WebCore/page/DOMWindow.cpp:
(WebCore::isLoadingInHeadlessMode):
(WebCore::DOMWindow::screenX const):
(WebCore::DOMWindow::screenY const):
* Tools/TestWebKitAPI/cocoa/TestUIDelegate.h:
* Tools/TestWebKitAPI/cocoa/TestUIDelegate.mm:

Additionally add support for an API test for this change, by exposing this delegate method via an
ObjC block property.

(-[TestUIDelegate _webView:getWindowFrameWithCompletionHandler:]):

Canonical link: https://commits.webkit.org/259983@main




More information about the webkit-changes mailing list