[webkit-changes] [WebKit/WebKit] 688149: [WebGPU] forceFallbackAdapter CTS test fails (251629)

mwyrzykowski noreply at github.com
Fri Feb 3 15:29:03 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 688149b429be877859932aecb386b215a2c60717
      https://github.com/WebKit/WebKit/commit/688149b429be877859932aecb386b215a2c60717
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2023-02-03 (Fri, 03 Feb 2023)

  Changed paths:
    M Source/WebCore/Modules/WebGPU/GPU.cpp
    M Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUImpl.cpp
    M Source/WebGPU/WebGPU/Adapter.mm
    M Source/WebGPU/WebGPU/Instance.mm

  Log Message:
  -----------
  [WebGPU] forceFallbackAdapter CTS test fails (251629)
https://bugs.webkit.org/show_bug.cgi?id=251629
<radar://104976449>

Reviewed by Myles C. Maxfield.

The spec says to return nullptr from requestAdapter if the
forceFallback adapter is not supported.

Now we get 0 failures (3 skips, 6 passes), on the requestAdapter
CTS tests.

* Source/WebCore/Modules/WebGPU/GPU.cpp:
(WebCore::GPU::requestAdapter):
* Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUImpl.cpp:
(PAL::WebGPU::GPUImpl::requestAdapter):
* Source/WebGPU/WebGPU/Adapter.mm:
(WebGPU::Adapter::requestDevice):
* Source/WebGPU/WebGPU/Instance.mm:
(WebGPU::Instance::requestAdapter):
(wgpuInstanceRequestAdapter):
(wgpuInstanceRequestAdapterWithBlock):

Canonical link: https://commits.webkit.org/259844@main




More information about the webkit-changes mailing list