[webkit-changes] [WebKit/WebKit] 2cf23d: Cherry-pick 259775 at main (886d4c8f6d38). https://bu...

[Chris Dumez]

  Branch: refs/heads/webkitglib/2.38
  Home:   https://github.com/WebKit/WebKit
  Commit: 2cf23dac44a99e36fc89bd5c2fc37aa6691a8811
      https://github.com/WebKit/WebKit/commit/2cf23dac44a99e36fc89bd5c2fc37aa6691a8811
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-02-04 (Sat, 04 Feb 2023)

  Changed paths:
    M Source/WebCore/platform/network/NetworkStorageSession.cpp

  Log Message:
  -----------
  Cherry-pick 259775 at main (886d4c8f6d38). https://bugs.webkit.org/show_bug.cgi?id=251601

    Fix bug in NetworkStorageSession::clientSideCookieCap() found by new libcpp assertions
    https://bugs.webkit.org/show_bug.cgi?id=251601
    rdar://104963759

    Reviewed by Kate Cheney.

    The code was dereferencing pageID without checking if it was std::nullopt
    first.

    * Source/WebCore/platform/network/NetworkStorageSession.cpp:
    (WebCore::NetworkStorageSession::clientSideCookieCap const):

    Canonical link: https://commits.webkit.org/259775@main


  Commit: 248b27757083e002e7f55ffe3e80dd9a4a6c3abd
      https://github.com/WebKit/WebKit/commit/248b27757083e002e7f55ffe3e80dd9a4a6c3abd
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-02-04 (Sat, 04 Feb 2023)

  Changed paths:
    M Source/WebCore/PAL/pal/spi/cocoa/MediaToolboxSPI.h
    M Source/WebKit/Shared/mac/MediaFormatReader/MediaFormatReader.cpp

  Log Message:
  -----------
  Cherry-pick 259794 at main (d7a2a7053e05). https://bugs.webkit.org/show_bug.cgi?id=251617

    Fix bug in MediaFormatReader::copyTrackArray() found by new libcpp assertions
    https://bugs.webkit.org/show_bug.cgi?id=251617
    rdar://104967552

    Reviewed by Andy Estes and Jer Noble.

    Dont dereference `m_parseTracksStatus` if the action was aborted, since
    m_parseTracksStatus will be std::nullopt in this case.

    * Source/WebKit/Shared/mac/MediaFormatReader/MediaFormatReader.cpp:
    (WebKit::MediaFormatReader::copyTrackArray):

    Canonical link: https://commits.webkit.org/259794@main


  Commit: 5beb5792b8372a5ff4a272069b5c020f65a8f969
      https://github.com/WebKit/WebKit/commit/5beb5792b8372a5ff4a272069b5c020f65a8f969
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2023-02-04 (Sat, 04 Feb 2023)

  Changed paths:
    M Source/WebCore/loader/ContentFilter.cpp
    M Source/WebCore/loader/ContentFilter.h
    M Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentFilteringPlugIn.mm

  Log Message:
  -----------
  Cherry-pick 259802 at main (9efb18ab3957). https://bugs.webkit.org/show_bug.cgi?id=251649

    Don't terminate web process when showing content-filter-provided data that loads subresources
    https://bugs.webkit.org/show_bug.cgi?id=251649
    rdar://104928565

    Reviewed by Geoffrey Garen and Andy Estes.

    When a content filter blocks a load, it provides HTML to load instead.
    It loads this HTML as substitute data with a base URL of blockedPageURL().
    If this HTML tries to load anything, we would terminate the web content
    process because it was claiming a firstPartyForCookies the network process
    was unaware of.  This makes the network process aware in this case.

    Covered by an API test.

    * Source/WebCore/loader/ContentFilter.cpp:
    (WebCore::ContentFilter::blockedPageURL):
    (WebCore::blockedPageURL): Deleted.
    * Source/WebCore/loader/ContentFilter.h:
    * Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:
    (WebKit::NetworkResourceLoader::handleProvisionalLoadFailureFromContentFilter):
    * Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm:
    (-[LoadAlternateNavigationDelegate webViewWebContentProcessDidTerminate:]):
    (TEST):
    * Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentFilteringPlugIn.mm:
    (-[MockContentFilterEnabler initWithCoder:]):

    Canonical link: https://commits.webkit.org/259802@main


  Commit: b7dfb04fa0513e88942639764a3a5cbe620310a3
      https://github.com/WebKit/WebKit/commit/b7dfb04fa0513e88942639764a3a5cbe620310a3
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-02-04 (Sat, 04 Feb 2023)

  Changed paths:
    M Source/WebCore/css/calc/CSSCalcOperationNode.cpp

  Log Message:
  -----------
  Cherry-pick 259814 at main (a19262e5a43e). https://bugs.webkit.org/show_bug.cgi?id=251655

    Fix bug in CSSCalcOperationNode::createHypot() found by new libcpp assertions
    https://bugs.webkit.org/show_bug.cgi?id=251655
    rdar://104981701

    Reviewed by Ryosuke Niwa.

    fast/css/calc-parsing.html has been crashing on Internal bots since we enabled
    the new libcpp assertions. This was caused by CSSCalcOperationNode::createHypot()
    not checking if expectedCategory was std::nullopt before dereferencing it.

    * Source/WebCore/css/calc/CSSCalcOperationNode.cpp:
    (WebCore::CSSCalcOperationNode::createHypot):

    Canonical link: https://commits.webkit.org/259814@main


  Commit: 5855b42d8d3d38a84704b541ea32277064075894
      https://github.com/WebKit/WebKit/commit/5855b42d8d3d38a84704b541ea32277064075894
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-02-04 (Sat, 04 Feb 2023)

  Changed paths:
    M Source/WebCore/dom/Document.cpp

  Log Message:
  -----------
  Cherry-pick 259841 at main (f223f5839426). https://bugs.webkit.org/show_bug.cgi?id=251695

    Ref document in Document::postTask() lambda to make sure it stays alive during the task execution
    https://bugs.webkit.org/show_bug.cgi?id=251695

    Reviewed by Ryosuke Niwa.

    * Source/WebCore/dom/Document.cpp:
    (WebCore::Document::postTask):
    (WebCore::Document::pendingTasksTimerFired):

    Canonical link: https://commits.webkit.org/259841@main


Compare: https://github.com/WebKit/WebKit/compare/59c426f45e12...5855b42d8d3d