[webkit-changes] [WebKit/WebKit] a83d5a: imported/w3c/web-platform-tests/web-animations/res...
Antoine Quint
noreply at github.com
Wed Feb 1 22:26:51 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a83d5abf9aefebf1f2553b169b2391333caeae73
https://github.com/WebKit/WebKit/commit/a83d5abf9aefebf1f2553b169b2391333caeae73
Author: Antoine Quint <graouts at webkit.org>
Date: 2023-02-01 (Wed, 01 Feb 2023)
Changed paths:
M LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/baselineShift-expected.txt
M Source/WebCore/css/CSSProperties.json
M Source/WebCore/style/StyleBuilderCustom.h
Log Message:
-----------
imported/w3c/web-platform-tests/web-animations/responsive/baselineShift.html is a failure
https://bugs.webkit.org/show_bug.cgi?id=251490
Reviewed by Antti Koivisto.
The baseline-shift CSS property is represented by two different bits on RenderStyle. In the case of
"inherit" we would only forward one of the bits from the parent style. We now add a custom "inherit"
function to the style builder to correctly forward both bits from the parent style.
This fixes the remaining tests in the web-animations/responsive/baselineShift.html WPT which uses
"baseline-shift: inherit" in a @keyframes rule.
* LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/baselineShift-expected.txt:
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/style/StyleBuilderCustom.h:
(WebCore::Style::BuilderCustom::applyInheritBaselineShift):
Canonical link: https://commits.webkit.org/259738@main
More information about the webkit-changes
mailing list