[webkit-changes] [WebKit/WebKit] 70fad0: [web-animations] keyframes should be recomputed if...

Antoine Quint noreply at github.com
Wed Feb 1 22:24:31 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 70fad032590132bb48443215af1766a1bf3a5828
      https://github.com/WebKit/WebKit/commit/70fad032590132bb48443215af1766a1bf3a5828
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property-animation-expected.txt
    M Source/WebCore/animation/KeyframeEffect.cpp
    M Source/WebCore/animation/KeyframeEffect.h
    M Source/WebCore/style/CustomPropertyRegistry.cpp
    M Source/WebCore/style/CustomPropertyRegistry.h

  Log Message:
  -----------
  [web-animations] keyframes should be recomputed if a custom property registration changes
https://bugs.webkit.org/show_bug.cgi?id=251509

Reviewed by Antti Koivisto.

If the registration of a custom property is changed, we must recompute keyframes of any effects
with keyframes targeting that custom property. To that end, we add a new method on KeyframeEffect
that the CustomPropertyRegistry can call into to notify the change of a custom property's
registration.

* LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property-animation-expected.txt:
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::customPropertyRegistrationDidChange):
* Source/WebCore/animation/KeyframeEffect.h:
* Source/WebCore/style/CustomPropertyRegistry.cpp:
(WebCore::Style::CustomPropertyRegistry::registerFromAPI):
(WebCore::Style::CustomPropertyRegistry::registerFromStylesheet):
(WebCore::Style::CustomPropertyRegistry::notifyAnimationsOfCustomPropertyRegistration):
* Source/WebCore/style/CustomPropertyRegistry.h:

Canonical link: https://commits.webkit.org/259737@main




More information about the webkit-changes mailing list