[webkit-changes] [WebKit/WebKit] 1d24a4: Remove UploadButtonElement

Anne van Kesteren noreply at github.com
Sun Dec 31 05:32:04 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1d24a443395cd438712eee30e17e527395f37dd0
      https://github.com/WebKit/WebKit/commit/1d24a443395cd438712eee30e17e527395f37dd0
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2023-12-31 (Sun, 31 Dec 2023)

  Changed paths:
    M Source/WebCore/html/FileInputType.cpp

  Log Message:
  -----------
  Remove UploadButtonElement
https://bugs.webkit.org/show_bug.cgi?id=117777

Reviewed by Tim Nguyen.

A custom PseudoId does not require a subclass.

Based on:
https://chromium.googlesource.com/chromium/blink/+/0ef88d710ad04158caa9835932776dbe1d40f505

Also refactor getting a reference to the button into a static method.

* Source/WebCore/html/FileInputType.cpp:
(WebCore::FileInputType::createShadowSubtree):
(WebCore::FileInputType::disabledStateChanged):
(WebCore::FileInputType::attributeChanged):
(isType): Deleted.
(): Deleted.
(WebCore::UploadButtonElement::create): Deleted.
(WebCore::UploadButtonElement::createForMultiple): Deleted.
(WebCore::UploadButtonElement::createInternal): Deleted.
(WebCore::UploadButtonElement::UploadButtonElement): Deleted.

Canonical link: https://commits.webkit.org/272539@main




More information about the webkit-changes mailing list