[webkit-changes] [WebKit/WebKit] 2b997e: ::-apple-attachment-controls-container should be g...

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2b997ee28d1cc967b8dd04e5c453adf94ef1ba71
      https://github.com/WebKit/WebKit/commit/2b997ee28d1cc967b8dd04e5c453adf94ef1ba71
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2023-12-31 (Sun, 31 Dec 2023)

  Changed paths:
    M Source/WebCore/css/CSSSelector.cpp
    M Source/WebCore/css/SelectorPseudoElementMap.in
    M Source/WebCore/css/makeSelectorPseudoElementsMap.py
    M Source/WebCore/css/parser/CSSParserContext.cpp
    M Source/WebCore/css/parser/CSSParserContext.h
    M Source/WebCore/css/parser/CSSSelectorParserContext.cpp
    M Source/WebCore/css/parser/CSSSelectorParserContext.h

  Log Message:
  -----------
  ::-apple-attachment-controls-container should be gated behind ImageControlsEnabled
https://bugs.webkit.org/show_bug.cgi?id=266810
rdar://120268884

Reviewed by Tim Nguyen.

As ::-apple-attachment-controls-container is the sole -apple-prefixed
pseudo-element and only used for an unstable feature we stop treating
all -apple-prefixed pseudo-elements as valid and instead special case
this specific one and preference gate it.

The impact on web developers is that they can no longer rely on
-apple-prefixed pseudo-elements to be valid in WebKit-based browsers.

Additionally remove some no-op code in the related Python script.

* Source/WebCore/css/CSSSelector.cpp:
(WebCore::CSSSelector::parsePseudoElement):
* Source/WebCore/css/SelectorPseudoElementMap.in:
* Source/WebCore/css/makeSelectorPseudoElementsMap.py:
(enumerablePseudoType):
* Source/WebCore/css/parser/CSSParserContext.cpp:
(WebCore::add):
* Source/WebCore/css/parser/CSSParserContext.h:
* Source/WebCore/css/parser/CSSSelectorParserContext.cpp:
(WebCore::CSSSelectorParserContext::CSSSelectorParserContext):
(WebCore::add):
* Source/WebCore/css/parser/CSSSelectorParserContext.h:

Canonical link: https://commits.webkit.org/272538@main