[webkit-changes] [WebKit/WebKit] 7b0782: Remove NSCell-based-sizing from RenderThemeMac

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7b07821e498923b349108cd877609f8969d6b251
      https://github.com/WebKit/WebKit/commit/7b07821e498923b349108cd877609f8969d6b251
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2023-12-20 (Wed, 20 Dec 2023)

  Changed paths:
    M Source/WebCore/rendering/RenderThemeMac.h
    M Source/WebCore/rendering/RenderThemeMac.mm

  Log Message:
  -----------
  Remove NSCell-based-sizing from RenderThemeMac
https://bugs.webkit.org/show_bug.cgi?id=266620

Reviewed by Aditya Keerthi.

Apply the lessons from 272218 at main to RenderThemeMac. There is no need
for an NSCell to determine the size of a control.

Additionally, we make a number of things static that have no class
dependency and remove no-op final methods that were already no-op.

This lays the groundwork for merging more of ThemeMac into
RenderThemeMac.

* Source/WebCore/rendering/RenderThemeMac.h:
* Source/WebCore/rendering/RenderThemeMac.mm:
(WebCore::controlSizeFromPixelSize):
(WebCore::popupButtonMargins):
(WebCore::popupButtonSizes):
(WebCore::popupButtonPadding):
(WebCore::RenderThemeMac::adjustRepaintRect):
(WebCore::controlSizeForSystemFont):
(WebCore::controlSizeForFont):
(WebCore::sizeForFont):
(WebCore::sizeForSystemFont):
(WebCore::setSizeFromFont):
(WebCore::setFontFromControlSize):
(WebCore::RenderThemeMac::popupMenuSize const):
(WebCore::RenderThemeMac::updateCheckedState): Deleted.
(WebCore::RenderThemeMac::updateEnabledState): Deleted.
(WebCore::RenderThemeMac::updatePressedState): Deleted.
(WebCore::RenderThemeMac::controlSizeForFont const): Deleted.
(WebCore::RenderThemeMac::controlSizeForCell const): Deleted.
(WebCore::RenderThemeMac::setControlSize): Deleted.
(WebCore::RenderThemeMac::sizeForFont const): Deleted.
(WebCore::RenderThemeMac::sizeForSystemFont const): Deleted.
(WebCore::RenderThemeMac::setSizeFromFont const): Deleted.
(WebCore::RenderThemeMac::setFontFromControlSize const): Deleted.
(WebCore::RenderThemeMac::controlSizeForSystemFont const): Deleted.
(WebCore::RenderThemeMac::adjustTextFieldStyle const): Deleted.
(WebCore::RenderThemeMac::adjustTextAreaStyle const): Deleted.
(WebCore::RenderThemeMac::popupButtonMargins const): Deleted.
(WebCore::RenderThemeMac::popupButtonSizes const): Deleted.
(WebCore::RenderThemeMac::popupButtonPadding const): Deleted.
(WebCore::RenderThemeMac::adjustProgressBarStyle const): Deleted.
(WebCore::RenderThemeMac::setPopupButtonCellState): Deleted.
(WebCore::RenderThemeMac::popupButton const): Deleted.

Canonical link: https://commits.webkit.org/272403@main