[webkit-changes] [WebKit/WebKit] b3886f: Stop using CheckedPtr / CheckedRef with NetworkPro...

Chris Dumez noreply at github.com
Wed Dec 20 21:09:37 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b3886f3ddafc152b3a1e3d89ea0a392f0bdae35a
      https://github.com/WebKit/WebKit/commit/b3886f3ddafc152b3a1e3d89ea0a392f0bdae35a
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-12-20 (Wed, 20 Dec 2023)

  Changed paths:
    M Source/WebKit/NetworkProcess/Cookies/WebCookieManager.cpp
    M Source/WebKit/NetworkProcess/Cookies/WebCookieManager.h
    M Source/WebKit/NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.cpp
    M Source/WebKit/NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.h
    M Source/WebKit/NetworkProcess/NetworkContentRuleListManager.cpp
    M Source/WebKit/NetworkProcess/NetworkContentRuleListManager.h
    M Source/WebKit/NetworkProcess/NetworkProcess.h
    M Source/WebKit/Shared/Authentication/AuthenticationManager.cpp
    M Source/WebKit/Shared/Authentication/AuthenticationManager.h

  Log Message:
  -----------
  Stop using CheckedPtr / CheckedRef with NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=266731

Reviewed by Darin Adler.

Stop using CheckedPtr / CheckedRef with NetworkProcess. Use
WeakPtr / WeakRef instead to generate more actionable crashes.

* Source/WebKit/NetworkProcess/Cookies/WebCookieManager.cpp:
(WebKit::WebCookieManager::protectedProcess):
(WebKit::WebCookieManager::setHTTPCookieAcceptPolicy):
* Source/WebKit/NetworkProcess/Cookies/WebCookieManager.h:
* Source/WebKit/NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.cpp:
(WebKit::LegacyCustomProtocolManager::protectedNetworkProcess const):
(WebKit::LegacyCustomProtocolManager::startLoading):
(WebKit::LegacyCustomProtocolManager::stopLoading):
* Source/WebKit/NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.h:
* Source/WebKit/NetworkProcess/NetworkContentRuleListManager.cpp:
(WebKit::NetworkContentRuleListManager::protectedNetworkProcess const):
(WebKit::NetworkContentRuleListManager::contentExtensionsBackend):
* Source/WebKit/NetworkProcess/NetworkContentRuleListManager.h:
* Source/WebKit/NetworkProcess/NetworkProcess.h:
* Source/WebKit/Shared/Authentication/AuthenticationManager.cpp:
(WebKit::AuthenticationManager::protectedProcess const):
(WebKit::AuthenticationManager::didReceiveAuthenticationChallenge):
(WebKit::AuthenticationManager::negotiatedLegacyTLS const):
(WebKit::AuthenticationManager::checkedProcess const): Deleted.
* Source/WebKit/Shared/Authentication/AuthenticationManager.h:

Canonical link: https://commits.webkit.org/272402@main




More information about the webkit-changes mailing list