[webkit-changes] [WebKit/WebKit] e6b09f: Element fullscreen requests should be ignored whil...

Blaze Jayne noreply at github.com
Sat Dec 16 00:53:07 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e6b09fa8586148cd027a289c0a035b28150be7f4
      https://github.com/WebKit/WebKit/commit/e6b09fa8586148cd027a289c0a035b28150be7f4
  Author: BJ Burg <bburg at apple.com>
  Date:   2023-12-16 (Sat, 16 Dec 2023)

  Changed paths:
    M Source/WebCore/html/HTMLMediaElement.cpp
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSuspendAllMediaPlayback.mm

  Log Message:
  -----------
  Element fullscreen requests should be ignored while media is suspended.
rdar://116595009

Reviewed by Jer Noble.

It is undesirable to allow entering element fullscreen while media is suspended.
Check for this condition and bail out if needed.

* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::enterFullscreen):

* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSuspendAllMediaPlayback.mm:
(TEST): Added test case.

Originally-landed-as: 267815.495 at safari-7617-branch (64b3c403419f). rdar://119598052
Canonical link: https://commits.webkit.org/272172@main




More information about the webkit-changes mailing list