[webkit-changes] [WebKit/WebKit] 59ecda: rdar://115842409 (jsc_fuz/wktr: ASSERTION FAILED: ...

mscottapple noreply at github.com
Sat Dec 16 00:22:08 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 59ecda13ecdbda262ba243715f95756bd4936eae
      https://github.com/WebKit/WebKit/commit/59ecda13ecdbda262ba243715f95756bd4936eae
  Author: Scott Marcy <mscott at apple.com>
  Date:   2023-12-16 (Sat, 16 Dec 2023)

  Changed paths:
    A LayoutTests/fast/css/font-size-adjust-invalid-value-type-expected.txt
    A LayoutTests/fast/css/font-size-adjust-invalid-value-type.html
    M Source/WebCore/style/StyleBuilderConverter.h

  Log Message:
  -----------
  rdar://115842409 (jsc_fuz/wktr: ASSERTION FAILED: is<Target>(source) &WTF::downcast(Source &) [Target = WebCore::CSSValuePair, Source = const WebCore::CSSValue] at StyleBuilderConverter.h:1632)

Checked for an unexpected CSS type for 'font-size-adjust' and returns a default value instead of crashing.

Reviewed by anttijk.

This prevents a crash on downcasting when an unexpected `CSSValue` subclass is provided.

Combined changes:
* LayoutTests/fast/css/font-size-adjust-invalid-value-type-expected.txt: Added.
* LayoutTests/fast/css/font-size-adjust-invalid-value-type.html: Added.
* Source/WebCore/style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertFontSizeAdjust):

Originally-landed-as: 267815.526 at safari-7617-branch (92043c608a1c). rdar://119598353
Canonical link: https://commits.webkit.org/272171@main




More information about the webkit-changes mailing list