[webkit-changes] [WebKit/WebKit] 9af7d5: REGRESSION(271747 at main): [Win][GPUP] Rendering art...

Fujii Hironori noreply at github.com
Fri Dec 15 11:57:13 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9af7d54818e82be0c227867f99b474fcc5404435
      https://github.com/WebKit/WebKit/commit/9af7d54818e82be0c227867f99b474fcc5404435
  Author: Fujii Hironori <Hironori.Fujii at sony.com>
  Date:   2023-12-15 (Fri, 15 Dec 2023)

  Changed paths:
    M Source/WebKit/WebProcess/WebPage/wc/DrawingAreaWC.cpp
    M Source/WebKit/WebProcess/WebPage/wc/DrawingAreaWC.h

  Log Message:
  -----------
  REGRESSION(271747 at main): [Win][GPUP] Rendering artifact of AC mode
https://bugs.webkit.org/show_bug.cgi?id=266329

Reviewed by Don Olmstead.

After 271747 at main removed RemoteImageBufferProxy::createFlusher
implementation, repainting a window caused a rendering artifact for
Windows port. 271803 at main and 271892 at main were the previous attempt to
fix the problem. But they were wrong fixes.

This problem can be resoved just by using newly added
RemoteImageBufferSetProxy::flushFrontBufferAsync even though Windows
port doesn't use RemoteImageBufferSetProxy yet. Because both
RemoteImageBufferSet and RemoteImageBuffer are using a same
StreamWorkQueue, flushing RemoteImageBufferSet command also ensures
that preceding RemoteImageBuffer commands are also flushed.

* Source/WebKit/WebProcess/WebPage/wc/DrawingAreaWC.cpp:
* Source/WebKit/WebProcess/WebPage/wc/DrawingAreaWC.h:

Canonical link: https://commits.webkit.org/272141@main




More information about the webkit-changes mailing list