[webkit-changes] [WebKit/WebKit] 17788c: Web Inspector: Event badge popover remains visible...

Razvan Caliman - Apple noreply at github.com
Fri Dec 15 11:33:55 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 17788c3b60cf8d86de1adea98b589664ac3e1049
      https://github.com/WebKit/WebKit/commit/17788c3b60cf8d86de1adea98b589664ac3e1049
  Author: Razvan Caliman <rcaliman at apple.com>
  Date:   2023-12-15 (Fri, 15 Dec 2023)

  Changed paths:
    M Source/WebInspectorUI/UserInterface/Views/Popover.js
    M Source/WebInspectorUI/UserInterface/Views/TabBrowser.js

  Log Message:
  -----------
  Web Inspector: Event badge popover remains visible after clicking to jump to event breakpoint
https://bugs.webkit.org/show_bug.cgi?id=255795

Reviewed by Patrick Angle and Devin Rousso.

Make `WI.Popover` auto-dismiss whenever the selected tab of the `WI.TabBrowser` changes.

A popover is usually shown inside a tab in the tab browser. If the selected tab changes,
the context changes, so it makes sense to automatically dismiss the popover.

* Source/WebInspectorUI/UserInterface/Views/Popover.js:
(WI.Popover.prototype.dismiss):
(WI.Popover.prototype._addListenersIfNeeded):
(WI.Popover):

Canonical link: https://commits.webkit.org/272140@main




More information about the webkit-changes mailing list