[webkit-changes] [WebKit/WebKit] 7a80a4: [UIAsyncTextInput] Crash when pressing shift key w...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7a80a44bef3662e8d7e2de89f6c5ee978a597a4e
      https://github.com/WebKit/WebKit/commit/7a80a44bef3662e8d7e2de89f6c5ee978a597a4e
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2023-12-11 (Mon, 11 Dec 2023)

  Changed paths:
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

  Log Message:
  -----------
  [UIAsyncTextInput] Crash when pressing shift key with async text input enabled after 271417 at main
https://bugs.webkit.org/show_bug.cgi?id=266200
rdar://119472884

Reviewed by Aditya Keerthi.

Move the logic in `-handleKeyWebEvent:` out into `-_internalHandleKeyWebEvent:`, and invoke the
latter underneath `-shiftKeyStateChangedFrom:to:` to avoid triggering the "async text input
disabled" assertion from within our own code.

* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView handleKeyWebEvent:]):
(-[WKContentView _internalHandleKeyWebEvent:]):
(-[WKContentView shiftKeyStateChangedFrom:to:]):

Canonical link: https://commits.webkit.org/271882@main