[webkit-changes] [WebKit/WebKit] 34c74c: Replace a few `PackedCheckedPtr<RenderObject>` dat...
Chris Dumez
noreply at github.com
Mon Dec 11 09:48:10 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 34c74ccc0e3371ff3bbb65dcad4c15b22d36154c
https://github.com/WebKit/WebKit/commit/34c74ccc0e3371ff3bbb65dcad4c15b22d36154c
Author: Chris Dumez <cdumez at apple.com>
Date: 2023-12-11 (Mon, 11 Dec 2023)
Changed paths:
M Source/WTF/wtf/Forward.h
M Source/WTF/wtf/WeakPtr.h
M Source/WebCore/rendering/RenderElement.cpp
M Source/WebCore/rendering/RenderElement.h
M Source/WebCore/rendering/RenderObject.cpp
M Source/WebCore/rendering/RenderObject.h
Log Message:
-----------
Replace a few `PackedCheckedPtr<RenderObject>` data members with weak pointers
https://bugs.webkit.org/show_bug.cgi?id=266222
Reviewed by Darin Adler.
Replace a few `PackedCheckedPtr<RenderObject>` data members with weak pointers.
The crashes generated by WeakPtr are more actionable and this tested as
performance-neutral on the benchmarks we track.
This is a follow-up to 271749 at main.
* Source/WTF/wtf/Forward.h:
* Source/WTF/wtf/WeakPtr.h:
(WTF::WeakPtr::WeakPtr):
(WTF::WeakPtr::releaseImpl):
(WTF::PtrTraits>::WeakPtr):
(WTF::=):
(WTF::is):
(WTF::downcast):
(WTF::dynamicDowncast):
(WTF::operator==):
(WTF::WeakPtrImpl>::WeakPtr): Deleted.
* Source/WebCore/rendering/RenderElement.cpp:
* Source/WebCore/rendering/RenderElement.h:
* Source/WebCore/rendering/RenderObject.cpp:
* Source/WebCore/rendering/RenderObject.h:
Canonical link: https://commits.webkit.org/271881@main
More information about the webkit-changes
mailing list