[webkit-changes] [WebKit/WebKit] f1f3c6: [iOS] Tapping 'Look Up' hangs when async UIKit int...

Wenson Hsieh noreply at github.com
Sat Dec 9 13:08:28 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f1f3c6392ba01727d527df042087dd28d03e95a3
      https://github.com/WebKit/WebKit/commit/f1f3c6392ba01727d527df042087dd28d03e95a3
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2023-12-09 (Sat, 09 Dec 2023)

  Changed paths:
    A LayoutTests/editing/selection/ios/look-up-selected-text-expected.txt
    A LayoutTests/editing/selection/ios/look-up-selected-text.html
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

  Log Message:
  -----------
  [iOS] Tapping 'Look Up' hangs when async UIKit interactions are disabled
https://bugs.webkit.org/show_bug.cgi?id=266151
rdar://119434158

Reviewed by Megan Gardner.

Fix a hang under `-_defineForWebView:`; instead of calling back into itself, it should be calling
into the real implementation in `-defineForWebView:`.

* LayoutTests/editing/selection/ios/look-up-selected-text-expected.txt: Added.
* LayoutTests/editing/selection/ios/look-up-selected-text.html: Added.
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _defineForWebView:]):

Canonical link: https://commits.webkit.org/271813@main




More information about the webkit-changes mailing list