[webkit-changes] [WebKit/WebKit] 7a0c84: Expose the CFNetworkNetworkLoaderEnabled preferenc...

[Matthew Finkel]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7a0c84628901b577cd5e312d0cdb98aa22819324
      https://github.com/WebKit/WebKit/commit/7a0c84628901b577cd5e312d0cdb98aa22819324
  Author: Matthew Finkel <sysrqb at apple.com>
  Date:   2023-12-09 (Sat, 09 Dec 2023)

  Changed paths:
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.h
    M Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.serialization.in
    M Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
    M Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm
    M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h
    M Tools/WebKitTestRunner/TestController.cpp

  Log Message:
  -----------
  Expose the CFNetworkNetworkLoaderEnabled preference as testable with a tri-state
https://bugs.webkit.org/show_bug.cgi?id=262810
rdar://104615596

Reviewed by Alex Christensen.

This patch accomplishes two tasks:
1) Move the preference to "testable" status
2) Define the preference as a tri-state: { unset, false, true }

Task (1) is a simple change, and the preference is disabled in
WebKitTestRunner. The remainder of the patch accomplishes (2) by plumbing the
preferences current state as a std::optional<bool>.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.h:
* Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.serialization.in:
* Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
* Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::optionalExperimentalFeatureEnabled):
(WebKit::experimentalFeatureEnabled):
(WebKit::WebsiteDataStore::useNetworkLoader):
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:
* Tools/WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):

Canonical link: https://commits.webkit.org/271812@main