[webkit-changes] [WebKit/WebKit] f1350d: Add temporary directory support to _WKWebExtension...

[Timothy Hatcher]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f1350da694fea03048cedf20314aaff4bc9b28d9
      https://github.com/WebKit/WebKit/commit/f1350da694fea03048cedf20314aaff4bc9b28d9
  Author: Timothy Hatcher <timothy at apple.com>
  Date:   2023-12-08 (Fri, 08 Dec 2023)

  Changed paths:
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionControllerConfiguration.mm
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionControllerConfigurationPrivate.h
    M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionControllerConfigurationCocoa.mm
    M Source/WebKit/UIProcess/Extensions/WebExtensionControllerConfiguration.cpp
    M Source/WebKit/UIProcess/Extensions/WebExtensionControllerConfiguration.h
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionControllerConfiguration.mm
    M Tools/TestWebKitAPI/cocoa/WebExtensionUtilities.h
    M Tools/TestWebKitAPI/cocoa/WebExtensionUtilities.mm

  Log Message:
  -----------
  Add temporary directory support to _WKWebExtensionControllerConfiguration.
https://webkit.org/b/266041
rdar://problem/119346018

Reviewed by Brian Weinstein.

Adds a way to run extensions with temporary storage for testing persistence features.
Also removes the caching in createStorageDirectoryPath() which would cache the path
with the identifier or default path and never return a different value.

* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionControllerConfiguration.mm:
(+[_WKWebExtensionControllerConfiguration configurationWithIdentifier:]):
(+[_WKWebExtensionControllerConfiguration _temporaryConfiguration]):
(-[_WKWebExtensionControllerConfiguration encodeWithCoder:]):
(-[_WKWebExtensionControllerConfiguration initWithCoder:]):
(-[_WKWebExtensionControllerConfiguration debugDescription]):
(-[_WKWebExtensionControllerConfiguration _isTemporary]):
(-[_WKWebExtensionControllerConfiguration _storageDirectoryPath]):
* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionControllerConfigurationPrivate.h:
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionControllerConfigurationCocoa.mm:
(WebKit::WebExtensionControllerConfiguration::createStorageDirectoryPath): Fixed incorrect caching.
(WebKit::WebExtensionControllerConfiguration::createTemporaryStorageDirectoryPath): Added.
(WebKit::WebExtensionControllerConfiguration::copy const):
(WebKit::WebExtensionControllerConfiguration::declarativeNetRequestStoreDirectory):
* Source/WebKit/UIProcess/Extensions/WebExtensionControllerConfiguration.cpp:
(WebKit::WebExtensionControllerConfiguration::WebExtensionControllerConfiguration):
* Source/WebKit/UIProcess/Extensions/WebExtensionControllerConfiguration.h:
(WebKit::WebExtensionControllerConfiguration::createTemporary): Added.
(WebKit::WebExtensionControllerConfiguration::storageIsTemporary const): Added.
(WebKit::WebExtensionControllerConfiguration::storageDirectory const): Added.
(WebKit::WebExtensionControllerConfiguration::setStorageDirectory): Added.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionControllerConfiguration.mm:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/cocoa/WebExtensionUtilities.h:
* Tools/TestWebKitAPI/cocoa/WebExtensionUtilities.mm:
(-[TestWebExtensionManager initForExtension:]):
(-[TestWebExtensionManager initForExtension:extensionControllerConfiguration:]):
(TestWebKitAPI::Util::loadAndRunExtension):

Canonical link: https://commits.webkit.org/271741@main