[webkit-changes] [WebKit/WebKit] 50def5: [Wasm-GC] Fix missing write barrier in BBQJIT stru...

Asumu Takikawa noreply at github.com
Fri Dec 8 09:45:50 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 50def56d35577644e656719dba0e81bee8f571ac
      https://github.com/WebKit/WebKit/commit/50def56d35577644e656719dba0e81bee8f571ac
  Author: Asumu Takikawa <asumu at igalia.com>
  Date:   2023-12-08 (Fri, 08 Dec 2023)

  Changed paths:
    A JSTests/wasm/gc/bug266043.js
    M Source/JavaScriptCore/wasm/WasmBBQJIT.cpp

  Log Message:
  -----------
  [Wasm-GC] Fix missing write barrier in BBQJIT struct.set
https://bugs.webkit.org/show_bug.cgi?id=266043

Reviewed by Yusuke Suzuki.

Adds a missing write barrier for struct.set in BBQJIT. Also optimize how struct
mutation is done for initialization (e.g., struct.new), because the old approach
was compiling duplicate loads for the payload pointer.

* JSTests/wasm/gc/bug266043.js: Added.
* Source/JavaScriptCore/wasm/WasmBBQJIT.cpp:
(JSC::Wasm::BBQJIT::emitStructSet):
(JSC::Wasm::BBQJIT::emitStructPayloadSet):
(JSC::Wasm::BBQJIT::addStructNewDefault):
(JSC::Wasm::BBQJIT::addStructNew):

Canonical link: https://commits.webkit.org/271740@main




More information about the webkit-changes mailing list