[webkit-changes] [WebKit/WebKit] 0a661a: [WebGPU] float32-filterable is not properly valida...

mwyrzykowski noreply at github.com
Wed Dec 6 18:38:13 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0a661a76704f9b1e330821ea1203a10b8094da6a
      https://github.com/WebKit/WebKit/commit/0a661a76704f9b1e330821ea1203a10b8094da6a
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2023-12-06 (Wed, 06 Dec 2023)

  Changed paths:
    A LayoutTests/http/tests/webgpu/webgpu/api/validation/texture/float32_filterable-expected.txt
    M Source/WebCore/Modules/WebGPU/GPUFeatureName.h
    M Source/WebCore/Modules/WebGPU/GPUFeatureName.idl
    M Source/WebCore/Modules/WebGPU/Implementation/WebGPUConvertToBackingContext.cpp
    M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUFeatureName.h
    M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp
    M Source/WebGPU/WebGPU/BindGroup.mm
    M Source/WebGPU/WebGPU/HardwareCapabilities.mm
    M Source/WebKit/Shared/WebGPU/WebGPUFeatureName.serialization.in

  Log Message:
  -----------
  [WebGPU] float32-filterable is not properly validated in bind group creation
https://bugs.webkit.org/show_bug.cgi?id=265921
<radar://119227113>

Reviewed by Tadeu Zagallo.

We can only use float32 filtering textures in bind groups if the float32-filterable
feature is enabled.

* LayoutTests/http/tests/webgpu/webgpu/api/validation/texture/float32_filterable-expected.txt: Added.
Add passing expectation.

* Source/WebGPU/WebGPU/BindGroup.mm:
(WebGPU::hasBinding):
(WebGPU::is32bppFloatFormat):
(WebGPU::valid32bppFloatSampleType):
(WebGPU::Device::createBindGroup):

* Source/WebCore/Modules/WebGPU/GPUFeatureName.h:
(WebCore::convertToBacking):

* Source/WebCore/Modules/WebGPU/GPUFeatureName.idl:
* Source/WebCore/Modules/WebGPU/Implementation/WebGPUConvertToBackingContext.cpp:
(WebCore::WebGPU::ConvertToBackingContext::convertToBacking):

* Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUFeatureName.h:
Add missing float32-filterable feature.

* Source/WebGPU/WebGPU/HardwareCapabilities.mm:
(WebGPU::baseFeatures):
Add feature if the device supports it.

Canonical link: https://commits.webkit.org/271653@main




More information about the webkit-changes mailing list