[webkit-changes] [WebKit/WebKit] ae54cd: [WebGPU] Creating a ComputePipeline with a vertexS...

mwyrzykowski noreply at github.com
Wed Dec 6 18:04:23 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ae54cd2196fe0a8ccbe5796cc913a67b8ade8e93
      https://github.com/WebKit/WebKit/commit/ae54cd2196fe0a8ccbe5796cc913a67b8ade8e93
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2023-12-06 (Wed, 06 Dec 2023)

  Changed paths:
    M Source/WebCore/Modules/WebGPU/GPUProgrammableStage.idl
    M Source/WebGPU/WGSL/WGSLShaderModule.h
    M Source/WebGPU/WebGPU/ComputePipeline.mm
    M Source/WebGPU/WebGPU/Pipeline.mm
    M Source/WebGPU/WebGPU/RenderPipeline.mm
    M Source/WebGPU/WebGPU/ShaderModule.h
    M Source/WebGPU/WebGPU/ShaderModule.mm

  Log Message:
  -----------
  [WebGPU] Creating a ComputePipeline with a vertexShader module or similar should be an error
https://bugs.webkit.org/show_bug.cgi?id=265928
<radar://119234036>

Reviewed by Tadeu Zagallo.

Creating a pipeline now allows the entryPoint to be omitted
and the only suitable default will be chosen.

Also, if we attempt to create a compute pipeline with a vertex
shader or similar incorrect combinations, that should be an error.

* Source/WebCore/Modules/WebGPU/GPUProgrammableStage.idl:
* Source/WebGPU/WebGPU/ComputePipeline.mm:
(WebGPU::Device::createComputePipeline):
* Source/WebGPU/WebGPU/Pipeline.mm:
(WebGPU::createLibrary):
* Source/WebGPU/WebGPU/RenderPipeline.mm:
(WebGPU::Device::createRenderPipeline):
* Source/WebGPU/WebGPU/ShaderModule.h:
* Source/WebGPU/WebGPU/ShaderModule.mm:
(WebGPU::Device::createShaderModule):
(WebGPU::ShaderModule::ShaderModule):
(WebGPU::ShaderModule::convertPipelineLayout):
(WebGPU::ShaderModule::defaultVertexEntryPoint const):
(WebGPU::ShaderModule::defaultFragmentEntryPoint const):
(WebGPU::ShaderModule::defaultComputeEntryPoint const):

Canonical link: https://commits.webkit.org/271652@main




More information about the webkit-changes mailing list