[webkit-changes] [WebKit/WebKit] e3f733: [IFC][Ruby] inter-character annotation should beha...

Alan Baradlay noreply at github.com
Wed Dec 6 15:08:22 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e3f733456e6a062fc29d5df114ae970b941d0e94
      https://github.com/WebKit/WebKit/commit/e3f733456e6a062fc29d5df114ae970b941d0e94
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-12-06 (Wed, 06 Dec 2023)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp
    M Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.h

  Log Message:
  -----------
  [IFC][Ruby] inter-character annotation should behave as interlinear over in vertical mode
https://bugs.webkit.org/show_bug.cgi?id=265949

Reviewed by Antti Koivisto.

See https://drafts.csswg.org/css-ruby-1/#rubypos

(Add helpers to ensure we don't confuse ourselves in vertical writing mode)

* Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::processRubyBase):
(WebCore::Layout::InlineDisplayContentBuilder::applyRubyOverhang):
(WebCore::Layout::isInterlinearAnnotationBox): Deleted.
* Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp:
(WebCore::Layout::rubyPosition):
(WebCore::Layout::RubyFormattingContext::placeAnnotationBox):
(WebCore::Layout::RubyFormattingContext::sizeAnnotationBox):
(WebCore::Layout::RubyFormattingContext::adjustLayoutBoundsAndStretchAncestorRubyBase):
(WebCore::Layout::RubyFormattingContext::overhangForAnnotationBefore):
(WebCore::Layout::RubyFormattingContext::overhangForAnnotationAfter):
(WebCore::Layout::RubyFormattingContext::hasInterlinearAnnotation):
(WebCore::Layout::RubyFormattingContext::hasInterCharacterAnnotation):
(WebCore::Layout::isInterlinearAnnotation): Deleted.
* Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.h:

Canonical link: https://commits.webkit.org/271637@main




More information about the webkit-changes mailing list