[webkit-changes] [WebKit/WebKit] 8cd58d: REGRESSION ( Sonoma?): [ Sonoma release x86_64 ] T...

Timothy Hatcher noreply at github.com
Wed Dec 6 15:01:37 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8cd58dac3ab9b34d9c0cf79fd53770fed42614a8
      https://github.com/WebKit/WebKit/commit/8cd58dac3ab9b34d9c0cf79fd53770fed42614a8
  Author: Timothy Hatcher <timothy at apple.com>
  Date:   2023-12-06 (Wed, 06 Dec 2023)

  Changed paths:
    M Source/WTF/wtf/CallbackAggregator.h
    M Source/WTF/wtf/Ref.h
    M Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIRuntimeCocoa.mm

  Log Message:
  -----------
  REGRESSION ( Sonoma?): [ Sonoma release x86_64 ] Three TestWebKitAPI.WKWebExtensionAPITabs tests are a consistent timeout
https://webkit.org/b/263525
rdar://problem/117354451

Reviewed by Alex Christensen.

Add EagerCallbackAggregator, which is like CallbackAggregator, but ensures a callback is executed at
its first opportunity, ignoring subsequent triggers. This was needed for the reply mechanism used
by runtime.sendMessage and friends.

* Source/WTF/wtf/CallbackAggregator.h:
(WTF::EagerCallbackAggregator): Added.
* Source/WTF/wtf/Ref.h:
(WTF::Ref::operator* const): Added.
* Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIRuntimeCocoa.mm:
(WebKit::WebExtensionContext::runtimeSendMessage): Use EagerCallbackAggregator.

Canonical link: https://commits.webkit.org/271636@main




More information about the webkit-changes mailing list