[webkit-changes] [WebKit/WebKit] 1d0cf3: [WPE][GTK] `WebKitWebsiteData/cache` is crashing i...

Vitaly Dyachkov noreply at github.com
Tue Aug 29 02:11:26 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1d0cf34fdae6143b31c0ce57cee0272c7a55f0d7
      https://github.com/WebKit/WebKit/commit/1d0cf34fdae6143b31c0ce57cee0272c7a55f0d7
  Author: Vitaly Dyachkov <vitaly at igalia.com>
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
    M Source/WebKit/UIProcess/glib/WebProcessProxyGLib.cpp
    M Tools/TestWebKitAPI/glib/TestExpectations.json

  Log Message:
  -----------
  [WPE][GTK] `WebKitWebsiteData/cache` is crashing in debug builds
https://bugs.webkit.org/show_bug.cgi?id=260524

Reviewed by Michael Catanzaro.

In `WebProcessProxy::platformGetLaunchOptions()` we evaluate if
`websiteDataStore()` is `NULL`, which is true for prewarmed processes.

But there is an assert in it, so this call will crash in debug builds.

* Source/WebKit/UIProcess/glib/WebProcessProxyGLib.cpp:
(WebKit::WebProcessProxy::platformGetLaunchOptions):
* Tools/TestWebKitAPI/glib/TestExpectations.json:

Canonical link: https://commits.webkit.org/267395@main




More information about the webkit-changes mailing list