[webkit-changes] [WebKit/WebKit] c7e433: WebGL rendering contexts have redundant framebuffe...

Kimmo Kinnunen noreply at github.com
Tue Aug 29 00:41:58 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c7e4339d34a867f39dad1f7cd37ac46ef5982749
      https://github.com/WebKit/WebKit/commit/c7e4339d34a867f39dad1f7cd37ac46ef5982749
  Author: Kimmo Kinnunen <kkinnunen at apple.com>
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
    M Source/WebCore/html/canvas/WebGL2RenderingContext.cpp
    M Source/WebCore/html/canvas/WebGL2RenderingContext.h
    M Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp
    M Source/WebCore/html/canvas/WebGLRenderingContextBase.h

  Log Message:
  -----------
  WebGL rendering contexts have redundant framebuffer functions, TexImageSource typedef
https://bugs.webkit.org/show_bug.cgi?id=260381
rdar://problem/114072108

Reviewed by Dan Glastonbury.

Remove the unused functions and duplicated TexImageSource typedef.

Move ensureNotNull to a translation unit local free function.

* Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::getReadFramebufferBinding): Deleted.
(WebCore::WebGL2RenderingContext::restoreCurrentFramebuffer): Deleted.
* Source/WebCore/html/canvas/WebGL2RenderingContext.h:
* Source/WebCore/html/canvas/WebGLRenderingContext.cpp:
(WebCore::root):
* Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::ensureNotNull):
(WebCore::root):
(WebCore::WebGLRenderingContextBase::getReadFramebufferBinding): Deleted.
(WebCore::WebGLRenderingContextBase::ensureNotNull const): Deleted.
(WebCore::WebGLRenderingContextBase::enableOrDisable): Deleted.
(WebCore::WebGLRenderingContextBase::restoreCurrentFramebuffer): Deleted.
(WebCore::WebGLRenderingContextBase::restoreCurrentTexture2D): Deleted.
* Source/WebCore/html/canvas/WebGLRenderingContextBase.h:

Canonical link: https://commits.webkit.org/267394@main




More information about the webkit-changes mailing list