[webkit-changes] [WebKit/WebKit] 21d1fa: Don't use atomic operations when determining wheth...

Alex Christensen noreply at github.com
Fri Aug 4 18:03:20 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 21d1fa0f88d0d1a744dd02dfd651b952aed07b7b
      https://github.com/WebKit/WebKit/commit/21d1fa0f88d0d1a744dd02dfd651b952aed07b7b
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2023-08-04 (Fri, 04 Aug 2023)

  Changed paths:
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm

  Log Message:
  -----------
  Don't use atomic operations when determining whether to call CGImageSourceDisableHardwareDecoding or CGImageSourceEnableRestrictedDecoding
https://bugs.webkit.org/show_bug.cgi?id=259846
rdar://113419113

Reviewed by Chris Dumez.

In 266605 at main I introduced calls to std::call_once, and I got feedback that that is excessive because it is only ever called on the main thread.
This responds to that feedback by using a bool instead of a std::once_flag to do a non-atomic operation to check if we've called the functions yet.

* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::m_appHighlightsVisible):
* Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):

Canonical link: https://commits.webkit.org/266609@main




More information about the webkit-changes mailing list