[webkit-changes] [WebKit/WebKit] 014d6f: Better handling of NetworkLoad lifecycle inside wi...

Brady Eidson noreply at github.com
Fri Aug 4 17:34:31 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 014d6ff4b81cf471153af5faaf83dd6347503b6e
      https://github.com/WebKit/WebKit/commit/014d6ff4b81cf471153af5faaf83dd6347503b6e
  Author: Brady Eidson <beidson at apple.com>
  Date:   2023-08-04 (Fri, 04 Aug 2023)

  Changed paths:
    A LayoutTests/http/tests/security/resources/network-load-sw.js
    A LayoutTests/http/tests/security/resources/network-load-swasdf.py
    A LayoutTests/http/tests/security/resources/network-load.js
    A LayoutTests/http/tests/security/service-worker-network-load-expected.txt
    A LayoutTests/http/tests/security/service-worker-network-load.html
    M LayoutTests/platform/mac-wk1/TestExpectations
    M Source/WebKit/NetworkProcess/NetworkLoad.cpp

  Log Message:
  -----------
  Better handling of NetworkLoad lifecycle inside willPerformHTTPRedirection
https://bugs.webkit.org/show_bug.cgi?id=259830
rdar://113149435

Reviewed by Chris Dumez.

NetworkLoad::didCompleteWithError has lifecycle side effects, so account for that.

This lifecycle change was introduced in a refactor: https://commits.webkit.org/266246@main

* LayoutTests/http/tests/security/resources/network-load-sw.js: Added.
* LayoutTests/http/tests/security/resources/network-load-swasdf.py: Added.
* LayoutTests/http/tests/security/resources/network-load.js: Added.
* LayoutTests/http/tests/security/service-worker-network-load-expected.txt: Added.
* LayoutTests/http/tests/security/service-worker-network-load.html: Added.

* Source/WebKit/NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::willPerformHTTPRedirection):

Canonical link: https://commits.webkit.org/266608@main




More information about the webkit-changes mailing list