[webkit-changes] [WebKit/WebKit] 4b0345: [run-benchmarks] Use `ktrace artrace` for profilin...

hysu noreply at github.com
Tue Aug 1 14:26:26 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4b03459ba7f6a33a8e4b610ca229901d64e07eb7
      https://github.com/WebKit/WebKit/commit/4b03459ba7f6a33a8e4b610ca229901d64e07eb7
  Author: Hysu Xiong <hysu at apple.com>
  Date:   2023-08-01 (Tue, 01 Aug 2023)

  Changed paths:
    M Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py
    M Tools/Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py
    M Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py
    M Tools/Scripts/webkitpy/benchmark_runner/run_benchmark.py
    M Tools/Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py

  Log Message:
  -----------
  [run-benchmarks] Use `ktrace artrace` for profiling browser benchmarks
https://bugs.webkit.org/show_bug.cgi?id=259669
rdar://113167762

Reviewed by Dewei Zhu.

Up until now, the `--profile` argument in run-benchmarks hasn't done anything. This patch implements profiling using the `ktrace artrace` command.

The --profile argument has been modified to require a TRACE_TYPE argument, this can be either `full` or `profile`. It'll start profiling when the test starts, and save the resulting files to the directory specified in --diagnose-directory (or /tmp/ by default).

* Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
(BenchmarkRunner.__init__):
* Tools/Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
(BrowserDriver.profile):
* Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
(OSXBrowserDriver):
(OSXBrowserDriver.profile):
* Tools/Scripts/webkitpy/benchmark_runner/run_benchmark.py:
(config_argument_parser):
(parse_args):
(run_benchmark_plan):
* Tools/Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
(WebServerBenchmarkRunner.__init__):
(WebServerBenchmarkRunner):

Canonical link: https://commits.webkit.org/266492@main




More information about the webkit-changes mailing list