[webkit-changes] [WebKit/WebKit] 3bfd9b: [run-benchmark][WPE] Update cog and minibrowser-wp...

Carlos Alberto Lopez Perez noreply at github.com
Fri Apr 28 03:41:37 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3bfd9bb7a4574965bed070cb2f7a71ab8b7f195d
      https://github.com/WebKit/WebKit/commit/3bfd9bb7a4574965bed070cb2f7a71ab8b7f195d
  Author: Carlos Alberto Lopez Perez <clopez at igalia.com>
  Date:   2023-04-28 (Fri, 28 Apr 2023)

  Changed paths:
    M Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_cog_driver.py
    M Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowserwpe_driver.py

  Log Message:
  -----------
  [run-benchmark][WPE] Update cog and minibrowser-wpe browser drivers.
https://bugs.webkit.org/show_bug.cgi?id=256061

Reviewed by Philippe Normand.

Simplify the Cog browser driver to only have one browser driver for Cog.
In order to select the platform plugins for Cog the environment variables
COG_PLATFORM_NAME and COG_PLATFORM_PARAMS can be used now. Also allow to
start Cog from the run-minibrowser script.

Finally fix the driver for minibrowser-wpe to run the minibrowser binary
instead of Cog. For that the script sets the env var WPE_BROWSER=minibrowser

* Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_cog_driver.py:
(CogBrowserDriver):
(CogBrowserDriver.launch_url):
(CogBrowserDriver.prepare_env):
(CogFdoBrowserDriver): Deleted.
(CogFdoBrowserDriver.launch_url): Deleted.
(CogFdoBrowserDriver.launch_driver): Deleted.
* Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowserwpe_driver.py:
(WPEMiniBrowserDriver.launch_driver):
(WPEMiniBrowserDriver):
(WPEMiniBrowserDriver.prepare_env):

Canonical link: https://commits.webkit.org/263495@main




More information about the webkit-changes mailing list