[webkit-changes] [WebKit/WebKit] 2364ff: [glib] Cog doesn't launch when built/started withi...

Nikolas Zimmermann noreply at github.com
Fri Apr 28 03:20:31 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2364ff02346a5906d103bfc02c341ca8bc9b5ecb
      https://github.com/WebKit/WebKit/commit/2364ff02346a5906d103bfc02c341ca8bc9b5ecb
  Author: Nikolas Zimmermann <nzimmermann at igalia.com>
  Date:   2023-04-28 (Fri, 28 Apr 2023)

  Changed paths:
    M Source/WTF/wtf/glib/Sandbox.cpp
    M Source/WTF/wtf/glib/Sandbox.h
    M Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp

  Log Message:
  -----------
  [glib] Cog doesn't launch when built/started within podman container
https://bugs.webkit.org/show_bug.cgi?id=255975

Reviewed by Adrian Perez de Castro.

We intent to disable bubblewrap sandboxing when e.g. Cog is launched
within a container -- however we only handle docker -- extend that to
all OCI-compatible container execution engines (podman!).

No new tests -- not testable within our CI/CD environment.

* Source/WTF/wtf/glib/Sandbox.cpp:
(WTF::isInsideContainer):
(WTF::isInsideDocker): Deleted.
* Source/WTF/wtf/glib/Sandbox.h:
* Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:
(WebKit::ProcessLauncher::launchProcess):

Canonical link: https://commits.webkit.org/263494@main




More information about the webkit-changes mailing list