[webkit-changes] [WebKit/WebKit] 9ac904: [iOS] Captions are not rendered over fullscreen vi...

Eric Carlson noreply at github.com
Thu Apr 27 07:56:48 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9ac904fb21323f02c4236196d8bf0e1b30d0d8ea
      https://github.com/WebKit/WebKit/commit/9ac904fb21323f02c4236196d8bf0e1b30d0d8ea
  Author: Eric Carlson <eric.carlson at apple.com>
  Date:   2023-04-27 (Thu, 27 Apr 2023)

  Changed paths:
    M Source/WebCore/platform/cocoa/VideoFullscreenModelVideoElement.h
    M Source/WebCore/platform/cocoa/VideoFullscreenModelVideoElement.mm
    M Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm

  Log Message:
  -----------
  [iOS] Captions are not rendered over fullscreen video when UI-side compositing is enabled
https://bugs.webkit.org/show_bug.cgi?id=256017
rdar://108208265

Reviewed by Jer Noble.

* Source/WebCore/platform/cocoa/VideoFullscreenModelVideoElement.h:
* Source/WebCore/platform/cocoa/VideoFullscreenModelVideoElement.mm:
(WebCore::VideoFullscreenModelVideoElement::setVideoSizeFenced): Renamed from
setVideoInlineSizeFenced. Call HTMLMediaElement::setVideoFullscreenFrame as well as
HTMLMediaElement::setVideoInlineSizeFenced because they are the same when UI-side
compositing is enabled, and this is only called in that case.
(WebCore::VideoFullscreenModelVideoElement::setVideoInlineSizeFenced): Deleted.

* Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm:
(WebKit::VideoFullscreenManager::setVideoLayerFrameFenced): Call
VideoFullscreenModelVideoElement::setVideoSizeFenced.

Canonical link: https://commits.webkit.org/263454@main




More information about the webkit-changes mailing list