[webkit-changes] [WebKit/WebKit] dc4f94: Cherry-pick 262260 at main (dd5da1dca9b6). https://bu...

[Ahmad Saleem]

  Branch: refs/heads/webkitglib/2.38
  Home:   https://github.com/WebKit/WebKit
  Commit: dc4f949cff7c2560f971e32ae1da0f9a7918afa8
      https://github.com/WebKit/WebKit/commit/dc4f949cff7c2560f971e32ae1da0f9a7918afa8
  Author: Mark Lam <mark.lam at apple.com>
  Date:   2023-04-27 (Thu, 27 Apr 2023)

  Changed paths:
    M Source/JavaScriptCore/assembler/MacroAssembler.h

  Log Message:
  -----------
  Cherry-pick 262260 at main (dd5da1dca9b6). https://bugs.webkit.org/show_bug.cgi?id=254634

    Only CPU(X86_64) should do constant blinding.
    https://bugs.webkit.org/show_bug.cgi?id=254634
    <rdar://problem/107345556>

    Reviewed by Justin Michaud and Yusuke Suzuki.

    It is not relevant for CPUs with fixed alignment instruction sets.

    * Source/JavaScriptCore/assembler/MacroAssembler.h:
    (JSC::MacroAssembler::shouldBlind):

    Canonical link: https://commits.webkit.org/262260@main


  Commit: 54cf4727caf45bb0fbaa468b156f573a7c49de25
      https://github.com/WebKit/WebKit/commit/54cf4727caf45bb0fbaa468b156f573a7c49de25
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-04-27 (Thu, 27 Apr 2023)

  Changed paths:
    A LayoutTests/compositing/visibility/visibility-remove-layer-expected.html
    A LayoutTests/compositing/visibility/visibility-remove-layer.html
    M Source/WebCore/rendering/RenderLayer.cpp

  Log Message:
  -----------
  Cherry-pick 262284 at main (059e2bb75dc3). https://bugs.webkit.org/show_bug.cgi?id=253706

    RenderLayer::hasVisibleContent() incorrect when layer removed

    https://bugs.webkit.org/show_bug.cgi?id=253706
    rdar://problem/106860749

    Reviewed by Simon Fraser.

    This patch is to align WebKit with Blink / Chromium and Gecko / Firefox.

    Merge - https://chromium.googlesource.com/chromium/blink/+/c5587982b1ed1ec62452f5d2c93c0f385a3941a1

    Prior to this change, we were incorrectly dirtying
    RenderLayer::hasVisibleContent() when removing a RenderLayer from the layer
    tree. This caused us to incorrectly believe that the parent layer lacked
    visible content.

    * Source/WebCore/rendering/RenderLayer.cpp:
    (RenderLayer::removeChild):
    * LayoutTests/compositing/visibility/visibility-remove-layer.html: Add Test Case
    * LayoutTests/compositing/visibility/visibility-remove-layer-expected.html: Add Test Case

    Canonical link: https://commits.webkit.org/262284@main


Compare: https://github.com/WebKit/WebKit/compare/ef4bcf4c99da...54cf4727caf4