[webkit-changes] [WebKit/WebKit] 689746: Cherry-pick 263345 at main (1643a89b579b). https://bu...

[Rob Buis]

  Branch: refs/heads/webkitglib/2.40
  Home:   https://github.com/WebKit/WebKit
  Commit: 6897469101a42f0e0e660fc1a2d156cd5a55119e
      https://github.com/WebKit/WebKit/commit/6897469101a42f0e0e660fc1a2d156cd5a55119e
  Author: Rob Buis <rbuis at igalia.com>
  Date:   2023-04-25 (Tue, 25 Apr 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-values/hypot-pow-sqrt-computed-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-values/hypot-pow-sqrt-computed.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-values/round-mod-rem-computed-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-values/round-mod-rem-computed.html
    M Source/WebCore/css/calc/CSSCalcOperationNode.cpp
    M Source/WebCore/css/calc/CSSCalcOperationNode.h

  Log Message:
  -----------
  Cherry-pick 263345 at main (1643a89b579b). https://bugs.webkit.org/show_bug.cgi?id=254392

    css/css-values/hypot-pow-sqrt-computed.html WPT crashes
    https://bugs.webkit.org/show_bug.cgi?id=254392

    Reviewed by Tim Nguyen.

    When simplifying hypot CSSCalcOperationNodes we may have only one child and
    it may not be a CSSCalcPrimitiveValueNode, in that case do not simplify.

    Add a similar check and tests for round, mod and rem.

    * LayoutTests/imported/w3c/web-platform-tests/css/css-values/hypot-pow-sqrt-computed-expected.txt:
    * LayoutTests/imported/w3c/web-platform-tests/css/css-values/hypot-pow-sqrt-computed.html:
    * LayoutTests/imported/w3c/web-platform-tests/css/css-values/round-mod-rem-computed-expected.txt:
    * LayoutTests/imported/w3c/web-platform-tests/css/css-values/round-mod-rem-computed.html:
    * Source/WebCore/css/calc/CSSCalcOperationNode.cpp:
    (WebCore::CSSCalcOperationNode::combineChildren):
    * Source/WebCore/css/calc/CSSCalcOperationNode.h:

    Canonical link: https://commits.webkit.org/263345@main