[webkit-changes] [WebKit/WebKit] 59088b: [IFC][Integration][Line clamp] `LineClamp.currentL...
Ethan Wong
noreply at github.com
Tue Apr 25 03:20:57 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 59088ba850576159b6e3d3bf05d2717fc6893432
https://github.com/WebKit/WebKit/commit/59088ba850576159b6e3d3bf05d2717fc6893432
Author: Ethan Wong <e1hanw0ng at gmail.com>
Date: 2023-04-25 (Tue, 25 Apr 2023)
Changed paths:
A LayoutTests/fast/block/line-clamp-nested-blocks-with-layout-state-expected.html
A LayoutTests/fast/block/line-clamp-nested-blocks-with-layout-state.html
M Source/WebCore/page/LocalFrameViewLayoutContext.cpp
Log Message:
-----------
[IFC][Integration][Line clamp] `LineClamp.currentLineCount` should be propagated to the parent layoutState.
https://bugs.webkit.org/show_bug.cgi?id=255487
Reviewed by Alan Baradlay.
Since multiple children share the same parent context for line clamp,
`LineClamp.currentLineCount` set to the individual child should be propagated to
their parent layoutState. Otherwise, subsequent children may not see the current
state of this value during layout, causing incorrect line clamp results.
* LayoutTests/fast/block/line-clamp-nested-blocks-with-layout-state-expected.html: Added.
* LayoutTests/fast/block/line-clamp-nested-blocks-with-layout-state.html: Added.
* Source/WebCore/page/LocalFrameViewLayoutContext.cpp:
(WebCore::LocalFrameViewLayoutContext::popLayoutState):
Canonical link: https://commits.webkit.org/263360@main
More information about the webkit-changes
mailing list