[webkit-changes] [WebKit/WebKit] 8950ba: [IFC][line-clamp] LineLayout::contentBoxLogicalHei...

Alan Baradlay noreply at github.com
Mon Apr 24 06:46:56 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8950ba8945830962eb74f3c1db5cf70fea1c579d
      https://github.com/WebKit/WebKit/commit/8950ba8945830962eb74f3c1db5cf70fea1c579d
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-04-24 (Mon, 24 Apr 2023)

  Changed paths:
    M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp
    M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.h

  Log Message:
  -----------
  [IFC][line-clamp] LineLayout::contentBoxLogicalHeight should not depend on current RenderLayoutState
https://bugs.webkit.org/show_bug.cgi?id=255850

Reviewed by Antti Koivisto.

RenderLayoutState is only available during layout and while currently we call contentBoxLogicalHeight
only at layout, it should use the truncated flag instead.

* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::contentBoxLogicalHeight const):
(WebCore::LayoutIntegration::LineLayout::lastLineIndexForContentHeight const): Deleted.
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.h:

Canonical link: https://commits.webkit.org/263309@main




More information about the webkit-changes mailing list