[webkit-changes] [WebKit/WebKit] ba3513: [GTK] MiniBrowser: pressing ESC doesn't exit point...

Carlos Garcia Campos noreply at github.com
Mon Apr 24 06:28:40 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ba351310fb37c264bf3f20bec1cebf396703a547
      https://github.com/WebKit/WebKit/commit/ba351310fb37c264bf3f20bec1cebf396703a547
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2023-04-24 (Mon, 24 Apr 2023)

  Changed paths:
    M Tools/MiniBrowser/gtk/BrowserWindow.c

  Log Message:
  -----------
  [GTK] MiniBrowser: pressing ESC doesn't exit pointer lock mode
https://bugs.webkit.org/show_bug.cgi?id=255864

Reviewed by Adrian Perez de Castro.

This is because we have an accelerator to stop loading when ESC is
pressed, but it's always enabled. The key press is always consumed by
the accel and never passed to the view.

* Tools/MiniBrowser/gtk/BrowserWindow.c:
(webViewIsLoadingChanged): Disable the stop page load action when not loading.
(stopPageLoad): Do not close the search bar in stop page load action.

Canonical link: https://commits.webkit.org/263308@main




More information about the webkit-changes mailing list