[webkit-changes] [WebKit/WebKit] 8aebf5: [WebGPU] createPipeline should reject invalid modules
Tadeu Zagallo
noreply at github.com
Thu Apr 20 13:15:05 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8aebf55ac51b716d91fbfa9e731961da68980aff
https://github.com/WebKit/WebKit/commit/8aebf55ac51b716d91fbfa9e731961da68980aff
Author: Tadeu Zagallo <tzagallo at apple.com>
Date: 2023-04-20 (Thu, 20 Apr 2023)
Changed paths:
M Source/WebGPU/WebGPU/ComputePipeline.mm
M Source/WebGPU/WebGPU/RenderPipeline.mm
Log Message:
-----------
[WebGPU] createPipeline should reject invalid modules
https://bugs.webkit.org/show_bug.cgi?id=255722
rdar://108317064
Reviewed by Mike Wyrzykowski.
Currently we try to read the AST from an invalid module, which causes an assertion
failure. I think the assertion is reasonable, and to avoid it we should fail early
if the module is invalid.
* Source/WebGPU/WebGPU/ComputePipeline.mm:
(WebGPU::Device::createComputePipeline):
* Source/WebGPU/WebGPU/RenderPipeline.mm:
(WebGPU::Device::createRenderPipeline):
Canonical link: https://commits.webkit.org/263191@main
More information about the webkit-changes
mailing list